Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(helm): make capsule configuration name configurable via helm #1103

Merged
merged 5 commits into from
Jun 24, 2024
Merged

chore(helm): make capsule configuration name configurable via helm #1103

merged 5 commits into from
Jun 24, 2024

Conversation

sybnex
Copy link
Contributor

@sybnex sybnex commented Jun 7, 2024

As this is fixed in the helm templates we need a very hacky implementation to change this value.

We have like 150 groups which we are creating in a new configuration.
So I suggest to make this configuration templated as well.

@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Deploy Preview for capsule-documentation canceled.

Name Link
🔨 Latest commit 3720989
🔍 Latest deploy log https://app.netlify.com/sites/capsule-documentation/deploys/667027719b1e6500084f5029

@prometherion
Copy link
Member

LGTM, may I ask you to amend the commits with the DCO and change the Pull Request title to feat(helm): capsuleconfiguration name configurable?

Thanks!

@sybnex
Copy link
Contributor Author

sybnex commented Jun 10, 2024

LGTM, may I ask you to amend the commits with the DCO and change the Pull Request title to feat(helm): capsuleconfiguration name configurable?

Thanks!

I tried to, but this DCO ... seems to make trouble? I'm lost here, sorry.

@maxgio92
Copy link
Collaborator

maxgio92 commented Jun 12, 2024 •
edited
Loading

Hi @sybnex I got the problem, and I fixed.

JFI The current version of the DCO uses a version of Git that removed the dot ('.') considering it an invalid trailing crud character (commit).
But I see you're using likely a Git version > 2.42, as the period is in your author name in your commit, so the check while not matching the author names, wasn't passing.

Thanks

@maxgio92 maxgio92 changed the title Make capsule configuration name configurable via helm chore: make capsule configuration name configurable via helm Jun 12, 2024
@maxgio92
Copy link
Collaborator

maxgio92 commented Jun 12, 2024 •
edited
Loading

Hi @sybnex, may I ask you to update the chart documentation?
I.e.:

+| manager.options.capsuleConfiguration | string | `"default"` | Change the default name of the capsule configuration name |

You should be able to do it just by running make helm-docs from the root of the repository.

Overall LGTM

@maxgio92 maxgio92 changed the title chore: make capsule configuration name configurable via helm chore(helm): make capsule configuration name configurable via helm Jun 12, 2024
@oliverbaehler oliverbaehler merged commit b408d53 into projectcapsule:main Jun 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverbaehler oliverbaehler oliverbaehler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sybnex @prometherion @maxgio92 @oliverbaehler